HTTP/3: Improve static table compression to include values #38681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
JamesNK
commented
Nov 29, 2021
src/Servers/Kestrel/Core/src/Internal/Http/HttpHeaders.Generated.cs
Outdated
Show resolved
Hide resolved
JamesNK
changed the title
Tratcher
approved these changes
Nov 29, 2021
JamesNK
force-pushed
the
jamesnk/responseheaders-staticvalue
branch
from
debf2c1 to
2eacb37
Compare
JamesNK
changed the title
ghost
added this to the 
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33980
Improves on #38565
When writing known headers, check if the value also matches a static table entry. If it matches then write just an index for name and value.